-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes type error with Astro 4.15.x #2273
Conversation
🦋 Changeset detectedLatest commit: dbbdfd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me 👍
Confirmed locally that this fixes the issue with the latest Astro release in the monorepo but also in a user project running tsc --noEmit
like mentioned in the issue.
P.S. Noticed a few other issues in the monorepo with the latest Astro release that we would need to handle when updating the monorepo version, e.g. a type issue with getViteConfig
from astro/config
and also the location of .astro/types.d.ts
at the root of the monorepo which seems weird.
Yeah, I also noticed those. Asked @florian-lefebvre about the |
Description
utils/i18n.ts
: MissingfallbackType
property #2271i18n.routing.fallbackType
option added in Astro 4.15.0