Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes type error with Astro 4.15.x #2273

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Fixes type error with Astro 4.15.x #2273

merged 3 commits into from
Sep 2, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 2, 2024

Description

Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: dbbdfd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Sep 2, 2024
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit dbbdfd9
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66d5a2042bba610008ef68a9
😎 Deploy Preview https://deploy-preview-2273--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 6.15 KB (0%)
/_astro/*.js 22.33 KB (0%)
/_astro/*.css 13.72 KB (0%)

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me 👍

Confirmed locally that this fixes the issue with the latest Astro release in the monorepo but also in a user project running tsc --noEmit like mentioned in the issue.

P.S. Noticed a few other issues in the monorepo with the latest Astro release that we would need to handle when updating the monorepo version, e.g. a type issue with getViteConfig from astro/config and also the location of .astro/types.d.ts at the root of the monorepo which seems weird.

@delucis
Copy link
Member Author

delucis commented Sep 2, 2024

P.S. Noticed a few other issues in the monorepo with the latest Astro release that we would need to handle when updating the monorepo version, e.g. a type issue with getViteConfig from astro/config and also the location of .astro/types.d.ts at the root of the monorepo which seems weird.

Yeah, I also noticed those. Asked @florian-lefebvre about the types.d.ts one, but didn’t get a chance to track down the exact version change causing that.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Sep 2, 2024
@delucis delucis merged commit 746e0cd into main Sep 2, 2024
15 checks passed
@delucis delucis deleted the dx-1384/fix-2271 branch September 2, 2024 12:46
@astrobot-houston astrobot-houston mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript error in utils/i18n.ts: Missing fallbackType property
3 participants