Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nested content css styles #385

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

lorenzolewis
Copy link
Contributor

What kind of changes does this PR include?

  • Changes to Starlight code

Description

  • Fixes an issue where the CSS property margin-top isn't applied to content within imported components

Before:
Screenshot 2023-07-23 at 16 00 39

After:
Screenshot 2023-07-23 at 16 00 15

Signed-off-by: Lorenzo Lewis <lorenzo_lewis@icloud.com>
Signed-off-by: Lorenzo Lewis <lorenzo_lewis@icloud.com>
@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2023

🦋 Changeset detected

Latest commit: bed7603

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 23, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit bed7603
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64befee964fb4400080554de
😎 Deploy Preview https://deploy-preview-385--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jul 23, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why the > snuck in — thanks for fixing!

@delucis delucis added the 🌟 patch Change that triggers a patch release label Jul 24, 2023
@delucis delucis merged commit fb35397 into withastro:main Jul 24, 2023
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jul 24, 2023
@lorenzolewis lorenzolewis deleted the fix/markdown-styles branch July 24, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants