feat: add ability to reset injected answers #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bngo97
force-pushed
the
bngo/08-02-feat_add_ability_to_reset_injected_answers
branch
from
e49200a
to
5a74cc0
Compare
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bngo97
force-pushed
the
bngo/08-02-feat_add_ability_to_reset_injected_answers
branch
from
5a74cc0
to
76e51e7
Compare
nicholasyan
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
add the ability to clear injected answers
why
we use
prompt.injectto inject answers for testing. however, if a test adds too many injections on accident that don't get used by the test, then this leaks over to the next test which which causes test failures. instead, we should be able to reset the injected answers before each test to make sure it's cleanI believe this is what's causing flaky tests in https://linear.app/withgraphite/issue/GT-10743/look-into-why-tests-involving-promptsinject-fail-in-ci