Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autolink for RN 0.69 #7568

Merged
merged 7 commits into from
Aug 2, 2022
Merged

Fix autolink for RN 0.69 #7568

merged 7 commits into from
Aug 2, 2022

Conversation

gaguirre
Copy link
Contributor

This PR updates autolink script for both Android and iOS to make them compatible with RN 0.69
It should fix #7564 and also tackle an issue commented in #7547

I've also added some snapshot tests for the modified files (activityLinker.js and appDeletegateLinker.js). In order to do so, some fixtures were added: MainActivity.java and AppDelegate.mm files for RN 0.68 and 0.69

These tests execution is included in test-all command, but could be removed if necessary.

@gaguirre gaguirre marked this pull request as ready for review August 2, 2022 13:45
@yogevbd yogevbd merged commit 1dfcef1 into wix:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx rnn-link not updating App Delegate correctly (RN 0.69.2 - RNN 7.28.1)
2 participants