-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option: IgnoreExternalBrokenLinks
#140
Conversation
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 82.74% 83.27% +0.53%
==========================================
Files 20 20
Lines 1153 1160 +7
==========================================
+ Hits 954 966 +12
+ Misses 179 174 -5
Partials 20 20
Continue to review full report at Codecov.
|
@abhishalya Saw your issue this morning. We've this exact problem on a site I help maintain, 👍 on the feature from me! |
I can see this is marked as WIP but thought I'd mention:
|
@wjdp I agree. How about |
This adds a new option to produce a warning rather than an error for broken external links. It is quite useful for sites having hundreds of external links.
AllowExternalLinksToFail
IgnoreExternalBrokenLinks
@wjdp I've added the tests, can you have a look again :) |
@wjdp Any update on this one? |
Sorry about delay on this! |
No problem, thanks for the merge :) |
Do let me know if it is useful, we particularly required this while checking links for julialang.org site which has a large number of links.
I'll add tests and docs soon, if this idea looks good enough.
Closes #139
cc @wjdp