Apply IgnoreURLs regexs to internal and file URLs too #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chalin
commented
Sep 18, 2021
chalin
commented
- Closes IgnoreURLs fails if URL given is not the domain #109
- Solves the original request of IgnoreURLs doesn't work on relative URLs #168
|
Friendly ping @wjdp |
|
Friendly ping @wjdp - it has been two months now. Thanks. |
|
4 month ping @wjdp - do you have an ETA for when this PR is likely to be reviewed? Thanks. |
|
@wjdp will be good to have this reviewed and merged. Facing the same issue :/ |
|
Hi @chalin, very sorry for delay on this. Reading through the issues and MRs around this it would seem to make more sense to combine all ignoring into the |
|
Great! Thanks for the heads up. Looking forward to this new capability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.