This repository has been archived by the owner on Mar 16, 2019. It is now read-only.
Add support for TLS 1.2 when running Android 4 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when running Android KitKat against HTTPS servers that require TLS 1.1 or newer. Android KitKat includes TLS 1.1/1.2 support, but doesn't enable it by default. This PR enables it, modeling the fix on work done previously by the core React Native team to fix a similar issue with Fetch in RN (which does now work fine in KitKat with TLS 1.1+ thanks to facebook/react-native#9840).