Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Update ts-jest 22.0.1 -> 23.10.3 #410

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update ts-jest 22.0.1 -> 23.10.3 #410

wants to merge 3 commits into from

Conversation

kdela
Copy link

@kdela kdela commented Oct 1, 2018

Update ts-jest version from 22.0.1 to 23.10.3

#399

Copy link
Contributor

@r3nya r3nya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@r3nya r3nya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@Arelav Arelav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to create the same PR.
Also it requires to chage:

'^.+\\.tsx?$': resolve('config/jest/typescriptTransform.js'),

to just

 "^.+\\.tsx?$": "ts-jest",

according to this warning
ts-jest[main] (WARN) Replace any occurrences of "ts-jest/dist/preprocessor.js" or "<rootDir>/node_modules/ts-jest/preprocessor.js" in the 'transform' section of your Jest config with just "ts-jest".

@DorianGrey
Copy link
Collaborator

DorianGrey commented Oct 11, 2018

We've used the custom typescript transform file as a wrapper for ts-jest in the past because there were some issue with properly resolving the transformer in both non-ejected and ejected mode. However, CI indicates that it works fine with just using ts-jest, which should achieve the same we've used the wrapper for previously.

Just one issue left: ts-jest now complains that the jest version in use is not tested. It is still pinned to 20.0.4, and I'm not sure why - anyway, I think it'd be better to get rid of this warning. Would you mind updating jest as well (23.6 should be the most recent) and remove the pin?

@Arelav
Copy link

Arelav commented Oct 11, 2018

@DorianGrey Also we have to remove config/jest/typescriptTransform.js as well if it's not in use anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants