Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

added source-map-loader #62

Merged
merged 1 commit into from
May 24, 2017
Merged

added source-map-loader #62

merged 1 commit into from
May 24, 2017

Conversation

Place1
Copy link
Contributor

@Place1 Place1 commented May 20, 2017

I've added source-map-loader to the webpack config for development.
This allowed me to successfully use all the VSCode debugging goodness!

Here's the VSCode launch target I made:

{
  "version": "0.2.0",
  "configurations": [
    {
      "type": "chrome",
      "request": "launch",
      "name": "Launch Chrome",
      "url": "http://localhost:3000",
      "userDataDir": "${workspaceRoot}/.vscode/chrome",
      "linux": {
        "runtimeExecutable": "chromium-browser"
      },
      "webRoot": "${workspaceRoot}",
      "sourceMaps": true,
      "sourceMapPathOverrides": {
        "webpack:///*": "${workspaceRoot}/*"
      }
    }
  ]
}

I saw you working on a CRA 1.0 update which involves a webpack upgrade to v2. I'm fine if you want to wait on this one and I can update the patch after that PR is done. #61

@wmonk
Copy link
Owner

wmonk commented May 22, 2017

hey @Place1, thanks for this! Have merged in cra@1.0.4 now, so please can you rebase your PR against that!

The tests are all working fine now, so please run yarn run e2e at the root of the repo before you push.

@Place1 Place1 force-pushed the master branch 2 times, most recently from 1107c2c to 8083188 Compare May 22, 2017 14:12
@Place1
Copy link
Contributor Author

Place1 commented May 22, 2017

hey @wmonk I think that's all done now. Tests pass on my machine.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants