Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Strip flags 2 #171

Merged
merged 3 commits into from
Feb 21, 2023
Merged

chore: Strip flags 2 #171

merged 3 commits into from
Feb 21, 2023

Conversation

pinkforest
Copy link
Contributor

@pinkforest pinkforest commented Feb 20, 2023

Supercedes #158 (review)

Testing in CI

@pinkforest pinkforest requested a review from a team as a code owner February 20, 2023 21:22
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #171 (30e0946) into main (17ad5f5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   66.46%   66.47%           
=======================================
  Files          36       36           
  Lines        2773     2729   -44     
  Branches      686      691    +5     
=======================================
- Hits         1843     1814   -29     
+ Misses        384      366   -18     
- Partials      546      549    +3     
Impacted Files Coverage Δ
wnfs/src/common/metadata.rs 51.02% <0.00%> (-14.84%) ⬇️
wnfs/src/private/encrypted.rs 60.71% <0.00%> (-10.12%) ⬇️
wnfs/src/private/node.rs 73.30% <0.00%> (-3.17%) ⬇️
wnfs/src/private/file.rs 77.94% <0.00%> (-1.11%) ⬇️
wnfs/src/private/directory.rs 73.93% <0.00%> (-0.04%) ⬇️
wnfs/examples/private.rs 0.00% <0.00%> (ø)
wnfs/src/common/error.rs 0.00% <0.00%> (ø)
wnfs/examples/privateref.rs 0.00% <0.00%> (ø)
wnfs/src/common/blockstore.rs 46.42% <0.00%> (ø)
wnfs/src/private/hamt/node.rs 59.61% <0.00%> (+0.09%) ⬆️
... and 7 more

Copy link
Member

@appcypher appcypher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@appcypher
Copy link
Member

And as suggested by @pinkforest, it would be nice to have a build script give user different options based on their prefs.

@appcypher appcypher merged commit 600334f into main Feb 21, 2023
@appcypher appcypher deleted the appcypher/chore-strip-flags branch February 21, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants