Add dry run option, test, and documentation #823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
May 19, 2024
| @@ -405,6 +405,10 @@ def run( | |||
| msg = "First argument to `session.run` is a list. Did you mean to use `session.run(*args)`?" | |||
| raise ValueError(msg) | |||
|
|
|||
| if self._runner.global_config.dry_run: | |||
There was a problem hiding this comment.
Shouldn't these be moved down? It would not run {args} even if --dry-run was not set, because --install-only was set too.
henryiii
reviewed
May 19, 2024
| session, _ = self.make_session_and_runner() | ||
|
|
||
| with mock.patch("nox.command.run", autospec=True) as run: | ||
| session.run(sys.executable, "--version", dry_run=True) |
There was a problem hiding this comment.
This wasn't added. And I don't think it shovel be, though, I think is should be a command line flag only. Probably monkeypatch the value here instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #302 which requests for a dry run option to be added. This option displays to the console what steps would be taken when the command is run but does not actually run them.
As part of this PR I added a test and updated the docs accordingly. Please let me know what changes need to be made still and I am happy to fix up the PR.