-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building for Meteor 1.5 (not semver) #103
Comments
@KoenLav I got this same error when trying to build after updating! But I didn't have time to look into it. I got some kind of error specifying cannot read [0] of undefined (something like that, cant quite remember) How did you get it to work? Manually bypassing error? How did you do that? Would you just have to change the release version in .meteor folder to 1.5.0? |
@sferoze I manually edited the code in node_modules/meteor-desktop/dist. If you look at the error messages you'll be able to figure out where the errors arise from and you can comment that code (as the code is only used to do version checking for Meteor, and you know you're using the right version). This is not a production ready fix, hence I didn't save the code or anything. |
Fix bug #103 - cast Meteor release to semver version so it passes the checks
Better version checking is now released in v0.7.2 |
Works fine with Meteor 1.5 now! |
I get a new error now:
I don't know how this is possible but after inspecting the code I find that the concatenation of the function |
Building for Meteor 1.5 will produce an error first because:
release = release.match(/(^\d+.\d+.\d+)/gmi)[0];
won't match 1.5 (would only match 1.5.0), which is followed with an error in 'checkMeteorVersion':
if (!_semver2.default.satisfies(release, versionRange))
because 1.5 is not semver.
Exactly the same errors pop up within 'chooseStrategy'.
After manually bypassing all of these though, Meteor 1.5 appears to work just fine!
The text was updated successfully, but these errors were encountered: