Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config header Access-Control-Allow-Origin on LocalServer module #216

Merged
merged 3 commits into from
Nov 28, 2019

Conversation

cbh6
Copy link

@cbh6 cbh6 commented Dec 26, 2018

This will set allowOriginLocalServer: false in settings.json when scaffolding

When allowOriginLocalServer is set to true, it will set Access-Control-Allow-Origin = "*" header in LocalServer fileSystem responses.

Referenced issue #215

@codecov-io
Copy link

codecov-io commented Dec 26, 2018

Codecov Report

Merging #216 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   58.63%   58.62%   -0.02%     
==========================================
  Files          20       20              
  Lines        1494     1496       +2     
==========================================
+ Hits          876      877       +1     
- Misses        618      619       +1
Impacted Files Coverage Δ
skeleton/app.js 5.74% <0%> (ø) ⬆️
skeleton/modules/localServer.js 82.74% <50%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4f21b...e12ae0c. Read the comment docs.

@wojtkowiak wojtkowiak merged commit e12ae0c into wojtkowiak:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants