neuvector-manager - use python3.XX rather than python3 to build venv #28955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is convoluted, but if you use 'python3 -m venv' to build a venv then the venv's bin/python will point to 'python3' which will point to /usr/bin/python3. But melange SCA does not recognize 'python3' for a shebang dep (because it is a symlink). So... the change here is to use python3.XX (currently 3.12). That will get the venv built with 'python3' pointing to 'python3.12' and 'python3.12' pointing to /usr/bin/python3.12. Melange will correctly identify that this package depends on python3.12. There is still coming breakage as the other dependencies 'py3-urllib3' are not versioned, so at some point they will move to be python3.13. At that point this package will not have 'urllib' to use. This change does make the test pass and better to know that you use python3.12 then just assume any old python3 will work (it won't, because only one of them has the libraries installed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is convoluted, but if you use 'python3 -m venv' to build a venv then the venv's bin/python will point to 'python3' which will point to /usr/bin/python3. But melange SCA does not recognize 'python3' for a shebang dep (because it is a symlink).
So... the change here is to use python3.XX (currently 3.12).
That will get the venv built with 'python3' pointing to 'python3.12' and 'python3.12' pointing to /usr/bin/python3.12. Melange will correctly identify that this package depends on python3.12.
There is still coming breakage as the other dependencies 'py3-urllib3' are not versioned, so at some point they will move to be python3.13. At that point this package will not have 'urllib' to use.
This change does make the test pass and better to know that you use python3.12 then just assume any old python3 will work (it won't, because only one of them has the libraries installed)