Skip to content

Commit

Permalink
Increase allowed length for user token in db (#328)
Browse files Browse the repository at this point in the history
After update to latest version gitea and use oauth, gitea returns long token in my case it was >800 characters. DB schema of the table has varchar(500), I updated it to varchar(1000) to solve the problem.

* Fix length for gitea token/secret
  • Loading branch information
zloidemon authored and 6543 committed Sep 21, 2021
1 parent 3ed1e0a commit caa21dd
Show file tree
Hide file tree
Showing 6 changed files with 47 additions and 0 deletions.
12 changes: 12 additions & 0 deletions store/datastore/ddl/mysql/ddl_gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,10 @@ var migrations = []struct {
name: "update-builds-set-changed_files",
stmt: updateBuildsSetChangedfiles,
},
{
name: "update-table-set-users-token-and-secret-length",
stmt: updateTableSetUsersTokenAndSecretLength,
},
}

// Migrate performs the database migration. If the migration fails
Expand Down Expand Up @@ -745,3 +749,11 @@ ALTER TABLE builds ADD COLUMN changed_files TEXT
var updateBuildsSetChangedfiles = `
UPDATE builds SET changed_files='[]'
`

//
// 028_update_table_set_users_token_and_secret_length.sql
//

var updateTableSetUsersTokenAndSecretLength = `
ALTER TABLE users MODIFY user_token varchar(1000), MODIFY user_secret varchar(1000);
`
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-- name: update-table-set-users-token-and-secret-length

ALTER TABLE users MODIFY user_token varchar(1000), MODIFY user_secret varchar(1000);
13 changes: 13 additions & 0 deletions store/datastore/ddl/postgres/ddl_gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,10 @@ var migrations = []struct {
name: "update-builds-set-changed_files",
stmt: updateBuildsSetChangedfiles,
},
{
name: "update-table-set-users-token-and-secret-length",
stmt: updateTableSetUsersTokenAndSecretLength,
},
}

// Migrate performs the database migration. If the migration fails
Expand Down Expand Up @@ -747,3 +751,12 @@ ALTER TABLE builds ADD COLUMN changed_files TEXT;
var updateBuildsSetChangedfiles = `
UPDATE builds SET changed_files='[]'
`

//
// 028_update_table_set_users_token_and_secret_length.sql
//

var updateTableSetUsersTokenAndSecretLength = `
ALTER TABLE users ALTER COLUMN user_token TYPE varchar(1000);
ALTER TABLE users ALTER COLUMN user_secret TYPE varchar(1000);
`
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
-- name: update-table-set-users-token-and-secret-length

ALTER TABLE users ALTER COLUMN user_token TYPE varchar(1000);
ALTER TABLE users ALTER COLUMN user_secret TYPE varchar(1000);
12 changes: 12 additions & 0 deletions store/datastore/ddl/sqlite/ddl_gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,10 @@ var migrations = []struct {
name: "update-builds-set-changed_files",
stmt: updateBuildsSetChangedfiles,
},
{
name: "update-table-set-users-token-and-secret-length",
stmt: updateTableSetUsersTokenAndSecretLength,
},
}

// Migrate performs the database migration. If the migration fails
Expand Down Expand Up @@ -746,3 +750,11 @@ ALTER TABLE builds ADD COLUMN changed_files TEXT
var updateBuildsSetChangedfiles = `
UPDATE builds SET changed_files='[]'
`

//
// 028_update_table_set_users_token_and_secret_length.sql
//

var updateTableSetUsersTokenAndSecretLength = `
`
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-- name: update-table-set-users-token-and-secret-length

-- noop since sqlite do use TEXT

0 comments on commit caa21dd

Please sign in to comment.