Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Advanced Yaml anchors stopped working #103

Closed
laszlocph opened this issue Nov 14, 2019 · 2 comments · Fixed by #105
Closed

BUG: Advanced Yaml anchors stopped working #103

laszlocph opened this issue Nov 14, 2019 · 2 comments · Fixed by #105

Comments

@laszlocph
Copy link
Member

since the go modules change in v0.8.106 the bellow pattern cause Invalid or missing image

  slack: &slack
    image: plugins/slack
    channel: team-xx
    secrets: [ slack_webhook ]


  slack-staging-deploy:
    <<: *slack
@laszlocph
Copy link
Member Author

If only there was a test for it https://github.com/laszlocph/woodpecker/blob/master/cncd/pipeline/pipeline/frontend/yaml/config_test.go#L47 :o

@laszlocph
Copy link
Member Author

go-yaml/yaml#184 (comment)

This is the root cause as the fix was never merged, and the vendored fix was gone when we moved to Go Modules

@laszlocph laszlocph mentioned this issue Nov 14, 2019
Merged
@laszlocph laszlocph mentioned this issue Nov 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix anchors v2 woodpecker-ci/woodpecker
1 participant
@laszlocph