Migrating to yaml.v3 #106
Merged
Migrating to yaml.v3 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laszlocph
force-pushed
the
yaml-v3
branch
2 times, most recently
from
32b713d
to
f32f77b
Compare
laszlocph
commented
Nov 15, 2019
| @@ -54,10 +54,6 @@ volumes: | |||
| - /var/lib/mysql | |||
| - /opt/data:/var/lib/mysql | |||
| - /etc/configs:/etc/configs/:ro | |||
| ulimits: | |||
There was a problem hiding this comment.
dropped support for ulimits, man gotta focus..
laszlocph
commented
Nov 15, 2019
| @@ -44,7 +44,7 @@ func TestBoolTrue(t *testing.T) { | |||
| }) | |||
|
|
|||
| g.It("should throw error when invalid", func() { | |||
| in := []byte("{ }") // string value should fail parse | |||
| in := []byte("abc") // string value should fail parse | |||
There was a problem hiding this comment.
yaml.v3 interprets {} as a map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#103 another attempt to fix.
The monkeypatched yaml.v2 was not working properly. Trying to fix it the right way ™️