-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depends_on
randomly ignored
#200
Comments
This is a bug if it happens. There are a bunch of tests related to the depends_on and triggers (https://github.com/laszlocph/woodpecker/pull/32/files#diff-6d89f3729b326d59c411ba1c2c00c4750b3b60f840d2778307e49012f8c9439f) Will try to see if your case is covered in there, and if I can repro the issue. This sounds serious, so I will spend a couple of hours with it tomorrow. |
Made two tests: one trivial and one multithreaded for your case. Can you verify if it matches your case: 3849d1e I will try to come up with more extreme theories/testcases UPDATE: actually I think I see some nondeterministic behavior in the multithreaded test. |
A potential fix was merged and released in https://github.com/laszlocph/woodpecker/releases/tag/v0.14.0-rc.1 Basically if a pipeline depended on more than one pipeline, only the first pipeline outcome was regarded. This could explain your case, but best would be if you come back with a some stats after using it for a week or two. |
will deploy it now and report back |
running 14.rc for 8 days now, we didn't see new occurrences, I believe we can close this |
Thank god. |
I have a repo with 3 pipelines:
the
deploy.yml
contains:this works as expected most of the times, in the sense that:
build
andtest
pipelines to finish successfully before startingsome times, randomly, when
build
fails in a stage in the middle, andtest
succeeds,deploy
is triggered and executes. Why would that happen?Attaching a couple of screenshots:
The text was updated successfully, but these errors were encountered: