Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invisible pipeline ".drone.yaml" if ".drone" multi pipeline is used #239

Closed
6543 opened this issue Jul 5, 2021 · 3 comments · Fixed by #250
Closed

invisible pipeline ".drone.yaml" if ".drone" multi pipeline is used #239

6543 opened this issue Jul 5, 2021 · 3 comments · Fixed by #250
Labels
bug Something isn't working
Milestone

Comments

@6543
Copy link
Member

6543 commented Jul 5, 2021

if you use a folder to store pipelines in it, and call one of them .drone.yaml it wont show up in ui

@6543 6543 added the bug Something isn't working label Jul 5, 2021
@6543 6543 added this to the v0.14.0 milestone Jul 5, 2021
@ygbillet
Copy link
Contributor

ygbillet commented Jul 6, 2021

I investigate a bit this issue.

It seems to come from web/src/screens/repo/screens/build/components/procs.js.

I'm not so fluent in JavaScript, so i'm not sure how to proceed.

@ygbillet
Copy link
Contributor

ygbillet commented Jul 7, 2021

How it works today : if the name of "proc" (see JSON in browser) is drone, we assume we are not in multipipeline mode.

Two options :

  • Instead of checking names, we could check if there are multiple procs or only one. But i don't know how to do that (i never learn React).
  • Maybe we shouldn't change anything and write in the doc not to use ".drone.yml" or "drone.yml" as the name of the file. The rationale behind it : name of a file describes a "pipeline". A pipeline "drone" is not very explicit, better use : tests, lint, build, publish, docker, doc, etc.

@speatzle : what do you think ?

@6543
Copy link
Member Author

6543 commented Jul 19, 2021

@anbraten this one;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants