-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mutli-pipeline to Gitea #225
Conversation
from https://woodpecker.laszlo.cloud/multi-pipeline/ Signed-off-by: Yves-Gaël BILLET <ygbillet@ifotec.com>
A proposition for adding multi-pipeline to Gitea. |
Accept code format suggestion from @6543 Co-authored-by: 6543 <6543@obermui.de>
This addresses #131 for Gitea Anyone wants to test this? |
This Works for me, though it took me a while to figure out i need to set the Pipeline Path to .drone (the folder) and that if i have the pipelines .drone/.drone.yaml and .drone/.test.yaml the .drone.yml pipeline will run but the ui only shows the .test.yml one for me, is this a bug you can confirm? |
correct
You mean you have the multipipes in |
No i have the pipelines |
@laszlocph can you test whether a .drone/.drone.yml pipeline is also invisible in the UI when using github multi-pipeline? |
We need to reflect change in Dir() at gitea_oauth.go. But we will have a code duplication. We should probaby work in two steps
@6543 : what do you think ? |
Signed-off-by: Yves-Gaël BILLET <ygbillet@ifotec.com>
At the moment we have lot of different code and differnt code styles in remote. In the end I'd like to refactor it to have one Interface and a base implementation, each remote do extend&overwrite. For example: giteas webhook response have its own defined struct in woodpecker and we use the gitea-SDK, so we should use the Structs of the SDK since its up to date and tested ... |
OK. Do we need more work for this PR (multipipeline to GITEA) ? |
We have the same situation, would be nice to have it in the latest image. i can make a new issue for the invisible pipeline problem, i belive that is a general multipipeline issue anyway and not specific to gitea. |
I can merge it once I had time to give it a final "manual live" test |
Thanks ! Regarding #239, i will give it a try (i'm not the one who found this bug) |
I guess the documentation now needs to be amended accordingly. Currently, it still states the following:
|
from https://woodpecker.laszlo.cloud/multi-pipeline/
Signed-off-by: Yves-Gaël BILLET ygbillet@ifotec.com