Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist DepStatus of tasks #1610

Merged
merged 3 commits into from
Mar 11, 2023

Conversation

lukaszgyg
Copy link
Contributor

This PR is going the add the task DepStatus persistence support. This will allow the server to properly restore the state after restart. This change should fix the issue #1606

@lukaszgyg lukaszgyg marked this pull request as ready for review March 9, 2023 11:51
@alexef
Copy link
Contributor

alexef commented Mar 9, 2023

@anbraten if you can have a look 🙏

@lafriks lafriks added the bug Something isn't working label Mar 9, 2023
@lafriks
Copy link
Contributor

lafriks commented Mar 10, 2023

Please rebase with base

@anbraten anbraten changed the title Add the taks DepStatus persistence to proper restore after the restart Persist DepStatus of tasks Mar 11, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (a2f226f) 40.64% compared to head (78cf09d) 40.59%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1610      +/-   ##
==========================================
- Coverage   40.64%   40.59%   -0.06%     
==========================================
  Files         169      169              
  Lines       11083    11085       +2     
==========================================
- Hits         4505     4500       -5     
- Misses       6287     6294       +7     
  Partials      291      291              
Impacted Files Coverage Δ
server/model/task.go 0.00% <ø> (ø)
server/queue/persistent.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anbraten anbraten merged commit dc90f97 into woodpecker-ci:master Mar 11, 2023
@alexef
Copy link
Contributor

alexef commented Mar 14, 2023

I'm guessing we should also backport this to the release/0.15 branch. Will prepare the pr. LE: #1625

alexef pushed a commit to alexef/woodpecker that referenced this pull request Mar 14, 2023
anbraten pushed a commit that referenced this pull request Mar 15, 2023
backport #1610 to the `release/v0.15` branch

Co-authored-by: Lukasz <106734180+lukaszgyg@users.noreply.github.com>
@6543 6543 added the backport indicates that this pull needs/has a backport label Mar 15, 2023
@6543 6543 modified the milestones: 0.15.8, 1.0.0 Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport indicates that this pull needs/has a backport bug Something isn't working server skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants