Filter main branch #205
Merged
Filter main branch #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to view only builds from main/master.
laszlocph
approved these changes
May 27, 2021
|
One thing to note is that this filters only the fetched builds. Have you considered the paging behavior? Moving this to the api level? I know that that is a larger task.. so probably we merge this and extend it to the api some point. |
|
Yes, it would be best implemented in the api/backend. But even now, with the "show more builds" button, this is usable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I find myself often doing is scrolling through the builds in order to find the latest master build.
With this new button, it becomes easier.
By default, preserve the list of all builds from all branches. When clicked, show only main/master ones.
