Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up config environment variables for server and agent #218

Merged
merged 35 commits into from
Sep 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
06b9547
Remove deprecated env var variants
marians May 31, 2021
968793e
Update log messages
marians May 31, 2021
92ad089
Remove deprecated env variants from agent
marians May 31, 2021
cb51b03
Remove WOODPECKER_PASSWORD, WOODPECKER_SECRET
marians May 31, 2021
6524976
Remove redundant HOSTNAME
marians May 31, 2021
e068ab6
Re-order fields for consistency
marians May 31, 2021
1eddb3a
Add flag "lets-encrypt-path"
marians May 31, 2021
54dc324
Remove WOODPECKER_SECRET
marians May 31, 2021
db63d2d
Replace XDG_CACHE_HOME with WOODPECKER_LETS_ENCRYPT_PATH
marians May 31, 2021
9602a82
Update env vars in docker files
marians May 31, 2021
0b58510
Remove WOODPECKER_HOST
marians May 31, 2021
86c33fa
Revert removal of XDG_CACHE_HOME
marians Jun 7, 2021
ae44828
Remove flag definition
marians Jun 8, 2021
cb0ed94
Merge branch 'master' into server-remove-drone-env-variables
anbraten Sep 19, 2021
869fee7
cleanup cli env vars
anbraten Sep 21, 2021
b17bde7
cleanup info text
anbraten Sep 21, 2021
2a4af6b
add migrations
anbraten Sep 21, 2021
2e98871
Merge branch 'master' into server-remove-drone-env-variables
anbraten Sep 21, 2021
c845609
Merge remote-tracking branch 'upstream/master' into pr/marians/218
anbraten Sep 21, 2021
bf4b7d6
Merge remote-tracking branch 'upstream/master' into pr/marians/218
anbraten Sep 21, 2021
60d8f8b
Merge remote-tracking branch 'upstream/master' into pr/marians/218
anbraten Sep 24, 2021
8d7286d
replace DRONE_ prefix with WOODPECKER_
anbraten Sep 24, 2021
f0d934e
simplify docker-compose samples
anbraten Sep 24, 2021
0b56770
Merge branch 'remove-compose' into pr/marians/218
anbraten Sep 24, 2021
00abb24
update docs
anbraten Sep 24, 2021
50b9b5c
Merge branch 'master' into server-remove-drone-env-variables
6543 Sep 25, 2021
1b89959
Merge branch 'master' into server-remove-drone-env-variables
6543 Sep 28, 2021
84c0661
dont break if no need for
6543 Sep 28, 2021
18d20e0
Update cmd/agent/flags.go
anbraten Sep 28, 2021
685a490
Update cmd/agent/flags.go
anbraten Sep 28, 2021
31887ae
Update cmd/cli/main.go
anbraten Sep 28, 2021
c974885
Update cmd/cli/main.go
anbraten Sep 28, 2021
71c77ac
Update cmd/server/flags.go
anbraten Sep 28, 2021
a19ec2a
next
6543 Sep 28, 2021
5535d24
Merge remote-tracking branch 'main/master' into server-remove-drone-e…
6543 Sep 28, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .woodpecker/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,17 @@ pipeline:
image: golang:1.16
group: db-test
environment:
- DATABASE_DRIVER=postgres
- DATABASE_CONFIG=host=postgres user=postgres dbname=postgres sslmode=disable
- WOODPECKER_DATABASE_DRIVER=postgres
- WOODPECKER_DATABASE_CONFIG=host=postgres user=postgres dbname=postgres sslmode=disable
commands:
- go test -timeout 30s github.com/woodpecker-ci/woodpecker/server/store/datastore

test-mysql:
image: golang:1.16
group: db-test
environment:
- DATABASE_DRIVER=mysql
- DATABASE_CONFIG=root@tcp(mysql:3306)/test?parseTime=true
- WOODPECKER_DATABASE_DRIVER=mysql
- WOODPECKER_DATABASE_CONFIG=root@tcp(mysql:3306)/test?parseTime=true
commands:
- go test -timeout 30s github.com/woodpecker-ci/woodpecker/server/store/datastore

Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
FROM drone/ca-certs
EXPOSE 8000 9000 80 443

ENV DATABASE_DRIVER=sqlite3
ENV DATABASE_CONFIG=/var/lib/drone/drone.sqlite
ENV GODEBUG=netdns=go
ENV XDG_CACHE_HOME /var/lib/drone
ENV WOODPECKER_DATABASE_DATASOURCE=/var/lib/drone/drone.sqlite
ENV WOODPECKER_DATABASE_DRIVER=sqlite3
ENV XDG_CACHE_HOME=/var/lib/drone

ADD release/woodpecker-server /bin/

Expand Down
6 changes: 3 additions & 3 deletions Dockerfile.alpine
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ EXPOSE 8000 9000 80 443

RUN apk add -U --no-cache ca-certificates

ENV DATABASE_DRIVER=sqlite3
ENV DATABASE_CONFIG=/var/lib/drone/drone.sqlite
ENV GODEBUG=netdns=go
ENV XDG_CACHE_HOME /var/lib/drone
ENV WOODPECKER_DATABASE_DATASOURCE=/var/lib/drone/drone.sqlite
ENV WOODPECKER_DATABASE_DRIVER=sqlite3
ENV XDG_CACHE_HOME=/var/lib/drone

ADD release/woodpecker-server /bin/

Expand Down
106 changes: 53 additions & 53 deletions cli/exec/exec.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,31 +39,31 @@ var Command = cli.Command{
},
Flags: []cli.Flag{
cli.BoolTFlag{
EnvVar: "WOODPECKER_LOCAL",
Name: "local",
Usage: "build from local directory",
EnvVar: "DRONE_LOCAL,WOODPECKER_LOCAL",
},
cli.DurationFlag{
EnvVar: "WOODPECKER_TIMEOUT",
Name: "timeout",
Usage: "build timeout",
Value: time.Hour,
EnvVar: "DRONE_TIMEOUT,WOODPECKER_TIMEOUT",
},
cli.StringSliceFlag{
EnvVar: "WOODPECKER_VOLUMES",
Name: "volumes",
Usage: "build volumes",
EnvVar: "DRONE_VOLUMES,WOODPECKER_VOLUMES",
},
cli.StringSliceFlag{
EnvVar: "WOODPECKER_NETWORKS",
Name: "network",
Usage: "external networks",
EnvVar: "DRONE_NETWORKS,WOODPECKER_NETWORKS",
},
cli.StringFlag{
EnvVar: "WOODPECKER_DOCKER_PREFIX",
Name: "prefix",
Value: "drone",
Usage: "prefix containers created by drone",
EnvVar: "DRONE_DOCKER_PREFIX,WOODPECKER_DOCKER_PREFIX",
Hidden: true,
},
cli.StringSliceFlag{
Expand All @@ -86,207 +86,207 @@ var Command = cli.Command{
// workspace default
//
cli.StringFlag{
EnvVar: "WOODPECKER_WORKSPACE_BASE",
Name: "workspace-base",
Value: "/drone",
EnvVar: "DRONE_WORKSPACE_BASE,WOODPECKER_WORKSPACE_BASE",
},
cli.StringFlag{
EnvVar: "WOODPECKER_WORKSPACE_PATH",
Name: "workspace-path",
Value: "src",
EnvVar: "DRONE_WORKSPACE_PATH,WOODPECKER_WORKSPACE_PATH",
},
//
// netrc parameters
//
cli.StringFlag{
EnvVar: "WOODPECKER_NETRC_USERNAME",
Name: "netrc-username",
EnvVar: "DRONE_NETRC_USERNAME,WOODPECKER_NETRC_USERNAME",
},
cli.StringFlag{
EnvVar: "WOODPECKER_NETRC_PASSWORD",
Name: "netrc-password",
EnvVar: "DRONE_NETRC_PASSWORD,WOODPECKER_NETRC_PASSWORD",
},
cli.StringFlag{
EnvVar: "WOODPECKER_NETRC_MACHINE",
Name: "netrc-machine",
EnvVar: "DRONE_NETRC_MACHINE,WOODPECKER_NETRC_MACHINE",
},
//
// metadata parameters
//
cli.StringFlag{
EnvVar: "WOODPECKER_SYSTEM_ARCH",
Name: "system-arch",
Value: "linux/amd64",
EnvVar: "DRONE_SYSTEM_ARCH,WOODPECKER_SYSTEM_ARCH",
},
cli.StringFlag{
EnvVar: "WOODPECKER_SYSTEM_NAME",
Name: "system-name",
Value: "pipec",
EnvVar: "DRONE_SYSTEM_NAME,WOODPECKER_SYSTEM_NAME",
},
cli.StringFlag{
EnvVar: "WOODPECKER_SYSTEM_LINK",
Name: "system-link",
Value: "https://github.com/cncd/pipec",
EnvVar: "DRONE_SYSTEM_LINK,WOODPECKER_SYSTEM_LINK",
},
cli.StringFlag{
EnvVar: "WOODPECKER_REPO_NAME",
Name: "repo-name",
EnvVar: "DRONE_REPO_NAME,WOODPECKER_REPO_NAME",
},
cli.StringFlag{
EnvVar: "WOODPECKER_REPO_LINK",
Name: "repo-link",
EnvVar: "DRONE_REPO_LINK,WOODPECKER_REPO_LINK",
},
cli.StringFlag{
EnvVar: "WOODPECKER_REPO_REMOTE",
Name: "repo-remote-url",
EnvVar: "DRONE_REPO_REMOTE,WOODPECKER_REPO_REMOTE",
},
cli.StringFlag{
EnvVar: "WOODPECKER_REPO_PRIVATE",
Name: "repo-private",
EnvVar: "DRONE_REPO_PRIVATE,WOODPECKER_REPO_PRIVATE",
},
cli.IntFlag{
EnvVar: "WOODPECKER_BUILD_NUMBER",
Name: "build-number",
EnvVar: "DRONE_BUILD_NUMBER,WOODPECKER_BUILD_NUMBER",
},
cli.IntFlag{
EnvVar: "WOODPECKER_PARENT_BUILD_NUMBER",
Name: "parent-build-number",
EnvVar: "DRONE_PARENT_BUILD_NUMBER,WOODPECKER_PARENT_BUILD_NUMBER",
},
cli.Int64Flag{
EnvVar: "WOODPECKER_BUILD_CREATED",
Name: "build-created",
EnvVar: "DRONE_BUILD_CREATED,WOODPECKER_BUILD_CREATED",
},
cli.Int64Flag{
EnvVar: "WOODPECKER_BUILD_STARTED",
Name: "build-started",
EnvVar: "DRONE_BUILD_STARTED,WOODPECKER_BUILD_STARTED",
},
cli.Int64Flag{
EnvVar: "WOODPECKER_BUILD_FINISHED",
Name: "build-finished",
EnvVar: "DRONE_BUILD_FINISHED,WOODPECKER_BUILD_FINISHED",
},
cli.StringFlag{
EnvVar: "WOODPECKER_BUILD_STATUS",
Name: "build-status",
EnvVar: "DRONE_BUILD_STATUS,WOODPECKER_BUILD_STATUS",
},
cli.StringFlag{
EnvVar: "WOODPECKER_BUILD_EVENT",
Name: "build-event",
EnvVar: "DRONE_BUILD_EVENT,WOODPECKER_BUILD_EVENT",
},
cli.StringFlag{
EnvVar: "WOODPECKER_BUILD_LINK",
Name: "build-link",
EnvVar: "DRONE_BUILD_LINK,WOODPECKER_BUILD_LINK",
},
cli.StringFlag{
EnvVar: "WOODPECKER_BUILD_TARGET",
Name: "build-target",
EnvVar: "DRONE_BUILD_TARGET,WOODPECKER_BUILD_TARGET",
},
cli.StringFlag{
EnvVar: "WOODPECKER_COMMIT_SHA",
Name: "commit-sha",
EnvVar: "DRONE_COMMIT_SHA,WOODPECKER_COMMIT_SHA",
},
cli.StringFlag{
EnvVar: "WOODPECKER_COMMIT_REF",
Name: "commit-ref",
EnvVar: "DRONE_COMMIT_REF,WOODPECKER_COMMIT_REF",
},
cli.StringFlag{
EnvVar: "WOODPECKER_COMMIT_REFSPEC",
Name: "commit-refspec",
EnvVar: "DRONE_COMMIT_REFSPEC,WOODPECKER_COMMIT_REFSPEC",
},
cli.StringFlag{
EnvVar: "WOODPECKER_COMMIT_BRANCH",
Name: "commit-branch",
EnvVar: "DRONE_COMMIT_BRANCH,WOODPECKER_COMMIT_BRANCH",
},
cli.StringFlag{
EnvVar: "WOODPECKER_COMMIT_MESSAGE",
Name: "commit-message",
EnvVar: "DRONE_COMMIT_MESSAGE,WOODPECKER_COMMIT_MESSAGE",
},
cli.StringFlag{
EnvVar: "WOODPECKER_COMMIT_AUTHOR_NAME",
Name: "commit-author-name",
EnvVar: "DRONE_COMMIT_AUTHOR_NAME,WOODPECKER_COMMIT_AUTHOR_NAME",
},
cli.StringFlag{
EnvVar: "WOODPECKER_COMMIT_AUTHOR_AVATAR",
Name: "commit-author-avatar",
EnvVar: "DRONE_COMMIT_AUTHOR_AVATAR,WOODPECKER_COMMIT_AUTHOR_AVATAR",
},
cli.StringFlag{
EnvVar: "WOODPECKER_COMMIT_AUTHOR_EMAIL",
Name: "commit-author-email",
EnvVar: "DRONE_COMMIT_AUTHOR_EMAIL,WOODPECKER_COMMIT_AUTHOR_EMAIL",
},
cli.IntFlag{
EnvVar: "WOODPECKER_PREV_BUILD_NUMBER",
Name: "prev-build-number",
EnvVar: "DRONE_PREV_BUILD_NUMBER,WOODPECKER_PREV_BUILD_NUMBER",
},
cli.Int64Flag{
EnvVar: "WOODPECKER_PREV_BUILD_CREATED",
Name: "prev-build-created",
EnvVar: "DRONE_PREV_BUILD_CREATED,WOODPECKER_PREV_BUILD_CREATED",
},
cli.Int64Flag{
EnvVar: "WOODPECKER_PREV_BUILD_STARTED",
Name: "prev-build-started",
EnvVar: "DRONE_PREV_BUILD_STARTED,WOODPECKER_PREV_BUILD_STARTED",
},
cli.Int64Flag{
EnvVar: "WOODPECKER_PREV_BUILD_FINISHED",
Name: "prev-build-finished",
EnvVar: "DRONE_PREV_BUILD_FINISHED,WOODPECKER_PREV_BUILD_FINISHED",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_BUILD_STATUS",
Name: "prev-build-status",
EnvVar: "DRONE_PREV_BUILD_STATUS,WOODPECKER_PREV_BUILD_STATUS",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_BUILD_EVENT",
Name: "prev-build-event",
EnvVar: "DRONE_PREV_BUILD_EVENT,WOODPECKER_PREV_BUILD_EVENT",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_BUILD_LINK",
Name: "prev-build-link",
EnvVar: "DRONE_PREV_BUILD_LINK,WOODPECKER_PREV_BUILD_LINK",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_COMMIT_SHA",
Name: "prev-commit-sha",
EnvVar: "DRONE_PREV_COMMIT_SHA,WOODPECKER_PREV_COMMIT_SHA",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_COMMIT_REF",
Name: "prev-commit-ref",
EnvVar: "DRONE_PREV_COMMIT_REF,WOODPECKER_PREV_COMMIT_REF",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_COMMIT_REFSPEC",
Name: "prev-commit-refspec",
EnvVar: "DRONE_PREV_COMMIT_REFSPEC,WOODPECKER_PREV_COMMIT_REFSPEC",
},
cli.StringFlag{
anbraten marked this conversation as resolved.
Show resolved Hide resolved
EnvVar: "WOODPECKER_PREV_COMMIT_BRANCH",
Name: "prev-commit-branch",
EnvVar: "DRONE_PREV_COMMIT_BRANCH,WOODPECKER_PREV_COMMIT_BRANCH",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_COMMIT_MESSAGE",
Name: "prev-commit-message",
EnvVar: "DRONE_PREV_COMMIT_MESSAGE,WOODPECKER_PREV_COMMIT_MESSAGE",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_COMMIT_AUTHOR_NAME",
Name: "prev-commit-author-name",
EnvVar: "DRONE_PREV_COMMIT_AUTHOR_NAME,WOODPECKER_PREV_COMMIT_AUTHOR_NAME",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_COMMIT_AUTHOR_AVATAR",
Name: "prev-commit-author-avatar",
EnvVar: "DRONE_PREV_COMMIT_AUTHOR_AVATAR,WOODPECKER_PREV_COMMIT_AUTHOR_AVATAR",
},
cli.StringFlag{
EnvVar: "WOODPECKER_PREV_COMMIT_AUTHOR_EMAIL",
Name: "prev-commit-author-email",
EnvVar: "DRONE_PREV_COMMIT_AUTHOR_EMAIL,WOODPECKER_PREV_COMMIT_AUTHOR_EMAIL",
},
cli.IntFlag{
EnvVar: "WOODPECKER_JOB_NUMBER",
Name: "job-number",
EnvVar: "DRONE_JOB_NUMBER,WOODPECKER_JOB_NUMBER",
},
cli.StringSliceFlag{
EnvVar: "WOODPECKER_ENV",
Name: "env, e",
EnvVar: "DRONE_ENV,WOODPECKER_ENV",
},
},
}

func exec(c *cli.Context) error {
file := c.Args().First()
if file == "" {
file = ".drone.yml"
file = ".woodpecker.yml"
}

dat, err := ioutil.ReadFile(file)
Expand Down Expand Up @@ -314,7 +314,7 @@ func exec(c *cli.Context) error {
func execWithAxis(c *cli.Context, axis matrix.Axis) error {
file := c.Args().First()
if file == "" {
file = ".drone.yml"
file = ".woodpecker.yml"
}

metadata := metadataFromContext(c, axis)
Expand Down
Loading