Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Logging & Report to WebHook Caller back if pulls are disabled #369

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Extend Logging & Report to WebHook Caller back if pulls are disabled #369

merged 1 commit into from
Sep 27, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 27, 2021 •
edited
Loading

  • Add more logging
  • Format Code
  • Add TODOs
  • Fix nits
  • Delete two unused functions
  • Report to WebHook Caller back if pulls are disabled

@6543 6543 added enhancement improve existing features refactor delete or replace old code labels Sep 27, 2021
@6543 6543 added this to the 0.15.0 milestone Sep 27, 2021
@6543
Copy link
Member Author

6543 commented Sep 27, 2021

taken from #358

@6543 6543 changed the title Add more logging & code format & add TODOs & fix nits Extend Logging & Fix nits Sep 27, 2021
@6543
Copy link
Member Author

6543 commented Sep 27, 2021

as per in #281 (comment) do report to caller back if pull is disabled

@6543 6543 changed the title Extend Logging & Fix nits Extend Logging & Report to WebHook Caller back if pulls are disabled Sep 27, 2021
@6543 6543 mentioned this pull request Sep 27, 2021
Merged
4 tasks
anbraten
anbraten reviewed Sep 27, 2021
View reviewed changes
server/router/router.go Show resolved Hide resolved
server/api/hook.go Show resolved Hide resolved
@6543 6543 merged commit f81bd8c into woodpecker-ci:master Sep 27, 2021
@6543 6543 deleted the logging branch September 27, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@6543 @anbraten