Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go embed for web files and remove httptreemux #382

Merged
merged 10 commits into from
Sep 29, 2021
Merged

Use go embed for web files and remove httptreemux #382

merged 10 commits into from
Sep 29, 2021

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Sep 29, 2021 •
edited
Loading

closes #308

  • replace togo with go embed
  • replace httptreemux with gin

@anbraten anbraten added the refactor delete or replace old code label Sep 29, 2021
@anbraten anbraten mentioned this pull request Sep 29, 2021
Closed
@anbraten anbraten changed the title Use go embed for html files Use go embed for web files Sep 29, 2021
@anbraten anbraten added this to the 0.15.0 milestone Sep 29, 2021
@anbraten anbraten changed the title Use go embed for web files Use go embed for web files and replace httptreemux Sep 29, 2021
@anbraten anbraten changed the title Use go embed for web files and replace httptreemux Use go embed for web files and remove httptreemux Sep 29, 2021
@6543
Copy link
Member

6543 commented Sep 29, 2021

tools.go can be deleted ...

@anbraten
Copy link
Member Author

tools.go can be deleted ...

I think the ddl files for sql migrations still need togo.

@6543
Copy link
Member

6543 commented Sep 29, 2021

yes you are right until we did #234

@6543 6543 enabled auto-merge (squash) September 29, 2021 15:22
@6543 6543 merged commit ed6d3f3 into woodpecker-ci:master Sep 29, 2021
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Oct 27, 2021
@anbraten @6543
Use go embed for web files and remove httptreemux (woodpecker-ci#382)
df9e1f4 
- replace togo with go embed
- replace httptreemux with gin

closes woodpecker-ci#308
@6543 6543 mentioned this pull request Oct 28, 2021
Merged
@6543 6543 added the backport indicates that this pull needs/has a backport label Oct 28, 2021
anbraten added a commit that referenced this pull request Oct 28, 2021
@6543 @anbraten
Use go embed for web files and remove httptreemux (#382) (#489)
96155a4 
* Use go embed for web files and remove httptreemux (#382)

- replace togo with go embed
- replace httptreemux with gin

closes #308

* adapt

* ajust & cleanup

Co-authored-by: Anbraten <anton@ju60.de>
@6543 6543 mentioned this pull request Oct 30, 2021
Merged
@anbraten anbraten deleted the embed-web branch December 1, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport indicates that this pull needs/has a backport refactor delete or replace old code server
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

[Refactor] we should only use one router framework
2 participants
@anbraten @6543