Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Lint privileged plugin match and allow to be set empty #4084

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 4, 2024

Partially Backport #4053 and #4083

also let it understand WOODPECKER_PLUGINS_PRIVILEGED but not enforce any change

@6543 6543 added enhancement improve existing features security labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v2.7@688d984). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/server/setup.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/v2.7    #4084   +/-   ##
===============================================
  Coverage                ?   26.90%           
===============================================
  Files                   ?      394           
  Lines                   ?    27556           
  Branches                ?        0           
===============================================
  Hits                    ?     7415           
  Misses                  ?    19439           
  Partials                ?      702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lafriks lafriks merged commit 9b18a90 into woodpecker-ci:release/v2.7 Sep 5, 2024
9 checks passed
@6543 6543 deleted the backport-lint-privileged-plugin-match-error branch September 5, 2024 18:56
@woodpecker-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants