Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade urfave/cli to v2 #483

Merged
merged 10 commits into from
Oct 27, 2021
Merged

Upgrade urfave/cli to v2 #483

merged 10 commits into from
Oct 27, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 27, 2021 •
edited
Loading

  • migrate urfave/ci v1 -> v2
  • refactor cli (format flag)
  • log error if agent can not listen on port 3000

close #452

@6543 6543 added refactor delete or replace old code dependencies labels Oct 27, 2021
@6543 6543 added this to the 0.15.0 milestone Oct 27, 2021
@6543 6543 requested a review from anbraten October 27, 2021 01:23
anbraten
anbraten approved these changes Oct 27, 2021
View reviewed changes
cli/common/flags.go Outdated Show resolved Hide resolved
@6543 6543 enabled auto-merge (squash) October 27, 2021 19:01
@6543 6543 merged commit 798c2bc into woodpecker-ci:master Oct 27, 2021
@6543 6543 deleted the urfave-cli-v2-migration branch October 27, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
dependencies refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

Upgrade urfave/cli to v2
2 participants
@6543 @anbraten