Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing of netrc credentials to clone step #492

Merged
merged 12 commits into from
Nov 25, 2021

Conversation

anbraten
Copy link
Member

closes #479

@anbraten anbraten added bug Something isn't working server labels Oct 28, 2021
@anbraten anbraten added this to the 0.15.0 milestone Oct 28, 2021
@6543
Copy link
Member

6543 commented Oct 28, 2021

https://github.com/woodpecker-ci/woodpecker/pull/492/files#diff-a18d8d720eb5f833ad6f93acf56edd1655defc1147766e4338e7df9e768b177dR135

Need it too
(Own clone step)

Later I would set a allowlist tor images able to use specific securety scopes ... but thats later

@anbraten anbraten requested a review from 6543 October 28, 2021 12:08
@6543
Copy link
Member

6543 commented Oct 30, 2021

status: could not verify fix by manual testing :/

@anbraten
Copy link
Member Author

@6543 I have tested it with the adjusted code (with woodpeckerci/plugin-git:next).
Could you verify the repo you test has: private: false with https://ci.example.tld/api/repos/<owner>/<repo>.

My test config looks like:

pipeline:
  test:
    image: golang:1.16
    group: test
    commands:
      - env | grep CI_
      - echo "hello world 123"

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@6543 6543 enabled auto-merge (squash) November 25, 2021 20:22
@6543 6543 merged commit f2b6a5c into woodpecker-ci:master Nov 25, 2021
@anbraten anbraten deleted the fix-netrc-cred-passing branch November 25, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netrc not passed to clone container
2 participants