Fix bug where db file is posible moved outside of docker volume #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anbraten
reviewed
Oct 30, 2021
anbraten
reviewed
Oct 30, 2021
Co-authored-by: Anbraten <anton@ju60.de>
anbraten
reviewed
Oct 30, 2021
Co-authored-by: Anbraten <anton@ju60.de>
anbraten
previously approved these changes
Oct 30, 2021
6543
commented
Oct 30, 2021
anbraten
reviewed
Oct 30, 2021
anbraten
approved these changes
Oct 30, 2021
|
well ... yes - this will be just 3 checks once we do fail hard (no fallback) in next version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#494 (comment) introduced a bug, where a migration function can remove the sqlite3 file outside of the mounted docker volume.
that would result in a data lose after a container recreate.
this fix it by only rename the file if in same folder else just use the old path as fallback and put warnings into the log