Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to set oauth redirect host in dev mode #586

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Dec 9, 2021

This setting allows to set a special redirect host address (like http://localhost:8000) and still use WOODPECKER_HOST for the public address which is for example used for the webhooks.

@anbraten
Copy link
Member Author

anbraten commented Dec 9, 2021

Maybe it would also be a solution, to make it the other way around, so you can set the normal host (WOODPECKER_HOST) to http://localhost:8000 and have an additional option WOODPECKER_DEV_WEBHOOK_HOST to set the host for webhooks differently. Need to check where WOODPECKER_HOST is used as well.

cmd/server/server.go Outdated Show resolved Hide resolved
@anbraten anbraten requested a review from 6543 December 13, 2021 19:03
@6543 6543 added this to the 0.15.0 milestone Dec 13, 2021
@6543 6543 added the enhancement improve existing features label Dec 13, 2021
@6543 6543 merged commit 3bee904 into woodpecker-ci:master Dec 13, 2021
@anbraten anbraten deleted the dev-oauth branch December 13, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants