Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gitlab generic webhooks instead of drone-ci-service #620

Merged
merged 2 commits into from
Dec 19, 2021
Merged

Use gitlab generic webhooks instead of drone-ci-service #620

merged 2 commits into from
Dec 19, 2021

Conversation

anbraten
Copy link
Member

Benefits:

  • the webhook delivery history of the drone-ci-service is broken (no way to check if a webhook was successfully delivered by Gitlab)
  • drone-ci-service has limited events support (for example no comment or branch deleted event)
  • independent from drone integration in general

@anbraten anbraten added the enhancement improve existing features label Dec 18, 2021
@anbraten anbraten added this to the 0.15.0 milestone Dec 18, 2021
@6543
Copy link
Member

6543 commented Dec 18, 2021 •
edited
Loading

you have to adjust the moc responces

@anbraten anbraten requested a review from 6543 December 19, 2021 00:04
@6543 6543 merged commit ed0a9fd into woodpecker-ci:master Dec 19, 2021
@anbraten anbraten deleted the gitlab-webhhooks branch December 19, 2021 00:12
@6543 6543 added the forge/gitlab gitlab forge related label Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features forge/gitlab gitlab forge related
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anbraten @6543