Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ChangedFiles for Github & Gitlab PRs and Gitea pushes #697

Merged
merged 22 commits into from
Jan 17, 2022
Merged

Support ChangedFiles for Github & Gitlab PRs and Gitea pushes #697

merged 22 commits into from
Jan 17, 2022

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Jan 16, 2022 •
edited by 6543
Loading

closes #555

load changed files for Github and Gitlab PRs
Gitea is waiting for go-gitea/gitea#18228

TODOs:

  • test gitlab in real
  • update gitlab webhook fixtures

@anbraten anbraten added this to the 0.15.0 milestone Jan 16, 2022
6543
6543 reviewed Jan 16, 2022
View reviewed changes
server/api/hook.go Outdated Show resolved Hide resolved
6543
6543 reviewed Jan 17, 2022
View reviewed changes
server/api/hook.go Outdated Show resolved Hide resolved
@6543 6543 changed the title load changed files for PRs Extend support for ChangedFiles filter to Gitlab and PRs Jan 17, 2022
@6543 6543 mentioned this pull request Jan 17, 2022
Closed
@6543 6543 added enhancement improve existing features refactor delete or replace old code forge/gitlab gitlab forge related forge/gitea gitea forge related forge/github github forge related labels Jan 17, 2022
6543
6543 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK from my side

anbraten
anbraten commented Jan 17, 2022
View reviewed changes
server/remote/gitea/helper.go Show resolved Hide resolved
server/remote/github/github.go Show resolved Hide resolved
server/remote/github/parse.go Outdated Show resolved Hide resolved
server/remote/gitlab/convert.go Show resolved Hide resolved
server/remote/gitlab/convert.go Show resolved Hide resolved
server/remote/gitlab/gitlab.go Show resolved Hide resolved
anbraten
anbraten commented Jan 17, 2022
View reviewed changes
server/remote/gitlab/convert.go Show resolved Hide resolved
server/remote/gitlab/convert.go Show resolved Hide resolved
server/remote/github/parse.go Outdated Show resolved Hide resolved
server/remote/gitlab/convert.go Show resolved Hide resolved
server/remote/gitea/helper.go Show resolved Hide resolved
6543 and others added 2 commits January 17, 2022 23:11
@6543 @anbraten
Apply suggestions from code review
5d7bf53 
Co-authored-by: Anbraten <anton@ju60.de>
@6543 @anbraten
Update server/remote/gitea/helper.go
5e6a7ae 
Co-authored-by: Anbraten <anton@ju60.de>
@anbraten
Copy link
Member Author

lgtm

@anbraten anbraten changed the title Extend support for ChangedFiles filter to Gitlab and PRs Support ChangedFiles for PRs and Gitlab pushes Jan 17, 2022
@anbraten anbraten changed the title Support ChangedFiles for PRs and Gitlab pushes Support ChangedFiles for Github& Gitlab PRs and Gitlab pushes Jan 17, 2022
@anbraten anbraten changed the title Support ChangedFiles for Github& Gitlab PRs and Gitlab pushes Support ChangedFiles for Github & Gitlab PRs and Gitlab pushes Jan 17, 2022
@anbraten anbraten merged commit 401072a into woodpecker-ci:master Jan 17, 2022
@anbraten anbraten deleted the pr-changes branch January 17, 2022 22:47
@6543 6543 changed the title Support ChangedFiles for Github & Gitlab PRs and Gitlab pushes Support ChangedFiles for Github & Gitlab PRs and Gitea pushes Jan 31, 2022
@anbraten anbraten mentioned this pull request Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features forge/gitea gitea forge related forge/github github forge related forge/gitlab gitlab forge related refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

Lists of changed files of pull-requests are empty
2 participants
@anbraten @6543