Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pipeline compiler #699

Merged
merged 11 commits into from
Jan 17, 2022
Merged

Improve pipeline compiler #699

merged 11 commits into from
Jan 17, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 16, 2022 •
edited
Loading

Refactor

  • use constants for strings
  • more tests
  • move constraint code into own package

Enhance

  • all constrains use doublestart (glob pattern matching) now

@6543 6543 added enhancement improve existing features refactor delete or replace old code pipeline-config related to pipeline config files (.yaml) labels Jan 16, 2022
@6543 6543 added this to the 0.15.0 milestone Jan 16, 2022
@6543 6543 mentioned this pull request Jan 16, 2022
Merged
@6543 6543 requested a review from a team January 16, 2022 21:40
anbraten
anbraten reviewed Jan 17, 2022
View reviewed changes
docs/docs/20-usage/22-conditional-execution.md Outdated Show resolved Hide resolved
pipeline/frontend/yaml/constraint/constraint.go Outdated Show resolved Hide resolved
docs/docs/20-usage/22-conditional-execution.md Outdated Show resolved Hide resolved
pipeline/frontend/yaml/constraint/constraint.go Outdated Show resolved Hide resolved
6543 and others added 2 commits January 17, 2022 12:18
@6543 @anbraten
Apply suggestions from code review
9f112e6 
Co-authored-by: Anbraten <anton@ju60.de>
@6543 @anbraten
more specific
44fb65c 
Co-authored-by: Anbraten <anton@ju60.de>
@6543 6543 requested a review from anbraten January 17, 2022 13:19
@6543 @anbraten
Update pipeline/frontend/yaml/constraint/constraint.go
f17fa04 
Co-authored-by: Anbraten <anton@ju60.de>
@6543 6543 merged commit 04eb793 into woodpecker-ci:master Jan 17, 2022
@6543 6543 deleted the improve-compile-pipeline branch January 17, 2022 13:43
@6543 6543 changed the title Improve compile pipeline Improve pipeline compiler Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features pipeline-config related to pipeline config files (.yaml) refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@6543 @anbraten