Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: show date time on hover over time items #756

Merged
merged 12 commits into from
Feb 8, 2022
Merged

UI: show date time on hover over time items #756

merged 12 commits into from
Feb 8, 2022

Conversation

9p4
Copy link
Contributor

@9p4 9p4 commented Feb 7, 2022 •
edited
Loading

Adds a tooltip that shows the date and time when hovering over "started at" times.

tooltip

Resolves #707

@9p4
Copy link
Contributor Author

9p4 commented Feb 7, 2022 •
edited
Loading

Maybe ISO standard for the time isn't the way to do this but it's trivial to change. Do you all want the duration to be like this too?

EDIT: I've changed it to be formatted in YYYY-mm-dd HH:m:s

@6543 6543 added ui frontend related enhancement improve existing features labels Feb 7, 2022
@6543 6543 added this to the 0.15.0 milestone Feb 7, 2022
@6543
Copy link
Member

6543 commented Feb 7, 2022

@9p4 you have to look at https://ci.woodpecker-ci.org/woodpecker-ci/woodpecker/build/1955/27 format and linting :)

@9p4
Copy link
Contributor Author

9p4 commented Feb 7, 2022

I've fixed everything except for the restriction on the CSS import. The recommended method of importing the tooltip with import 'floating-vue/dist/style.css'; has the keyword dist in it, and is marked as an error by eslint. I can't find a way to integrate the default styles easily, so would it be fine if I just had eslint ignore that error?

anbraten
anbraten reviewed Feb 7, 2022
View reviewed changes
web/src/compositions/useBuild.ts Outdated Show resolved Hide resolved
web/package.json Outdated Show resolved Hide resolved
web/src/components/build-feed/BuildFeedItem.vue Outdated Show resolved Hide resolved
web/src/main.ts Outdated Show resolved Hide resolved
@6543
Copy link
Member

6543 commented Feb 8, 2022

thanks :) - i would say - let it merge 🚀

@6543 6543 enabled auto-merge (squash) February 8, 2022 22:21
anbraten
anbraten reviewed Feb 8, 2022
View reviewed changes
web/src/main.ts Show resolved Hide resolved
web/src/compositions/useBuild.ts Show resolved Hide resolved
@6543 6543 merged commit 7521336 into woodpecker-ci:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten left review comments

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features ui frontend related
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

UI: show date time on hover over time items
3 participants
@9p4 @6543 @anbraten