View better error if repo was deleted/renamed #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the repo was renamed, there's an issue with Gitea: it redirects the /api/v1/repos/<owner>/<repo>/hooks POST request to a GET request at the same URL. This URL returns the list of all hooks, thus the Gitea SDK can't parse the response into a single gitea.Hook type. A better error is also visisble if the repo was deleted. Closes woodpecker-ci#726
wxiaoguang
reviewed
Feb 21, 2022
6543
added
server
forge/gitea
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
- Coverage 52.22% 52.14% -0.08%
==========================================
Files 86 86
Lines 5944 5953 +9
==========================================
Hits 3104 3104
- Misses 2668 2676 +8
- Partials 172 173 +1
Continue to review full report at Codecov.
|
6543
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the repo was renamed, there's an issue with Gitea: it redirects the /api/v1/repos/<owner>/<repo>/hooks POST request to a GET request at the same URL (returns a 302 Found which always redirects to GET - it should return a 307 or woodpecker needs to request again with the correct repo).
This URL returns the list of all hooks, thus the Gitea SDK can't parse the response into a single gitea.Hook type. The PR includes a workaround for this case.
A better error is also visisble if the repo was deleted.
Closes #726