Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uppercase from_secrets #842

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Mar 19, 2022

Secret names where matched based on their lowercase value already just the conversion to lowercase for from_secrets was missing.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #842 (f9ef9b2) into master (80c72b5) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   51.76%   51.68%   -0.09%     
==========================================
  Files          80       80              
  Lines        6054     6054              
==========================================
- Hits         3134     3129       -5     
- Misses       2741     2746       +5     
  Partials      179      179              
Impacted Files Coverage Δ
server/logging/log.go 48.83% <0.00%> (-5.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49e2fd...f9ef9b2. Read the comment docs.

@anbraten anbraten added the bug Something isn't working label Mar 19, 2022
@6543 6543 added the backport indicates that this pull needs/has a backport label Mar 19, 2022
@6543 6543 merged commit 6ae7e2c into woodpecker-ci:master Mar 19, 2022
@6543 6543 added this to the 1.0.0 milestone Mar 19, 2022
@6543
Copy link
Member

6543 commented Mar 19, 2022

please backport ;)

@anbraten
Copy link
Member Author

I will try to fix the image filtering in from_secret first and then backport both to 0.15

@anbraten anbraten deleted the fix-from-secret branch March 20, 2022 08:29
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request May 17, 2022
Secret names where matched based on their lowercase value already just the conversion to lowercase for `from_secrets` was missing.
6543 added a commit that referenced this pull request May 17, 2022
Secret names where matched based on their lowercase value already just the conversion to lowercase for `from_secrets` was missing.

Co-authored-by: Anbraten <anton@ju60.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport indicates that this pull needs/has a backport bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants