-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uppercase from_secrets #842
Conversation
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
==========================================
- Coverage 51.76% 51.68% -0.09%
==========================================
Files 80 80
Lines 6054 6054
==========================================
- Hits 3134 3129 -5
- Misses 2741 2746 +5
Partials 179 179
Continue to review full report at Codecov.
|
please backport ;) |
I will try to fix the image filtering in from_secret first and then backport both to 0.15 |
Secret names where matched based on their lowercase value already just the conversion to lowercase for `from_secrets` was missing.
Secret names where matched based on their lowercase value already just the conversion to lowercase for
from_secrets
was missing.