-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[장바구니 협업 Step 1] 황펭(양이진) 미션 제출합니다. #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
Co-authored-by: 전증훈 <jeonjeunghoon@gmail.com>
devhyun637
approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 황펭~ 티케입니다!
레벨1에서 만났는데 또 만나니 반갑네요~
저도 이번미션 잘부탁드립니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
배포주소
안녕하세요 티케! 저번 레벨 1때와 같이 마지막 미션에서 다시 만나서 반갑습니다 😊
이번 미션은 아커와 페어로 진행했습니다!
진행한 커밋 내역입니다. 링크에서 확인해주시면 됩니다.! 보러가기
요구 사항
백엔드 세명의 서버를 선택할 수 있게 select를 만들었습니다.
도치와 엔초 서버의 경우 https 처리가 되어있지 않아 배포 환경에서는 현재 푸우 서버에서만 정상 동작합니다.!
요청에 대한 전체적인 동작은 요약하면 다음과 같습니다.
장바구니 요청
백엔드 세개의 서버와 연결하면서 기존 cartProducState atom을 serverName을 받을 수 있게 recoil의 atomFamily로 변경해주었습니다.
그러다 보니 모든 selector가 selectorFamily로 변경되어 사용하는 모든 커스텀 훅에서 serverName이 구독하는 형태가 되었습니다.
더 복잡해지고 있다는 생각이 들어 비동기 과정을 useFetchCartProducts 커스텀 훅으로 분리하고 그 훅에서 serverName에 따라 요청을 보내고 setCartProduct 하게 수정했습니다. recoil에서 serverName은 받지 않아도 되었고 serverName은 해당 훅과 ErrorBoundary의 key로만 사용하도록 수정했습니다. 😊
그 밖에 진행한 과정