warning: temporary with significant `Drop` can be early dropped --> src/lazy_merkle_tree.rs:985:17 | 984 | fn update_with_mutation(&self, index: usize, value: &H::Hash) { | ___________________________________________________________________- 985 | | let mut storage = self.storage.lock().expect("lock poisoned, terminating"); | | ^^^^^^^ 986 | | let leaf_index_in_dense_tree = index + (self.root_index << self.depth); 987 | | storage[leaf_index_in_dense_tree] = value.clone(); ... | 994 | | } 995 | | } | |_____- temporary `storage` is currently being dropped at the end of its contained scope | = note: this might lead to unnecessary resource contention = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening help: merge the temporary construction with its single usage | 985 ~ 986 + self.storage.lock().expect("lock poisoned, terminating").; | help: remove separated single usage | 987 - storage[leaf_index_in_dense_tree] = value.clone(); 987 + |

warning: temporary with significant `Drop` can be early dropped --> src/lazy_merkle_tree.rs:748:17 | 747 | fn update_with_mutation(&self, index: usize, value: &H::Hash) { | ___________________________________________________________________- 748 | | let mut storage = self.storage.lock().expect("lock poisoned, terminating"); | | ^^^^^^^ 749 | | let leaf_index_in_dense_tree = index + (self.root_index << self.depth); 750 | | storage[leaf_index_in_dense_tree] = value.clone(); ... | 757 | | } 758 | | } | |_____- temporary `storage` is currently being dropped at the end of its contained scope | = note: this might lead to unnecessary resource contention = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_tightening note: the lint level is defined here --> src/lib.rs:2:55 | 2 | #![warn(clippy::all, clippy::pedantic, clippy::cargo, clippy::nursery)] | ^^^^^^^^^^^^^^^ = note: `#[warn(clippy::significant_drop_tightening)]` implied by `#[warn(clippy::nursery)]` help: merge the temporary construction with its single usage | 748 ~ 749 + self.storage.lock().expect("lock poisoned, terminating").; | help: remove separated single usage | 750 - storage[leaf_index_in_dense_tree] = value.clone(); 750 + |

warning: redundant clone --> src/lazy_merkle_tree.rs:564:39 | 564 | let right = children.right.clone(); | ^^^^^^^^ help: remove this | note: cloned value is neither consumed nor mutated --> src/lazy_merkle_tree.rs:564:25 | 564 | let right = children.right.clone(); | ^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

warning: redundant clone --> src/lazy_merkle_tree.rs:563:37 | 563 | let left = children.left.clone(); | ^^^^^^^^ help: remove this | note: cloned value is neither consumed nor mutated --> src/lazy_merkle_tree.rs:563:24 | 563 | let left = children.left.clone(); | ^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `#[warn(clippy::redundant_clone)]` implied by `#[warn(clippy::all)]`

warning: docs for function returning `Result` missing `# Errors` section --> src/lazy_merkle_tree.rs:87:5 | 87 | / pub fn new_mmapped_with_dense_prefix_with_init_values( 88 | | depth: usize, 89 | | prefix_depth: usize, 90 | | empty_value: &H::Hash, 91 | | initial_values: &[H::Hash], 92 | | file_path: &str, 93 | | ) -> Result<LazyMerkleTree<H, Canonical>, DenseMMapError> { | |_____________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc note: the lint level is defined here --> src/lib.rs:2:22 | 2 | #![warn(clippy::all, clippy::pedantic, clippy::cargo, clippy::nursery)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`

warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` --> src/lazy_merkle_tree.rs:87:5 | 87 | / pub fn new_mmapped_with_dense_prefix_with_init_values( 88 | | depth: usize, 89 | | prefix_depth: usize, 90 | | empty_value: &H::Hash, 91 | | initial_values: &[H::Hash], 92 | | file_path: &str, 93 | | ) -> Result<LazyMerkleTree<H, Canonical>, DenseMMapError> { | |_____________________________________________________________^ | = help: either add some descriptive text or remove the attribute = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use note: the lint level is defined here --> src/lib.rs:2:9 | 2 | #![warn(clippy::all, clippy::pedantic, clippy::cargo, clippy::nursery)] | ^^^^^^^^^^^ = note: `#[warn(clippy::double_must_use)]` implied by `#[warn(clippy::all)]`

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/