Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gearsbot example uses illogical elevaltor setpoints #3151

Closed
sciencewhiz opened this issue Feb 2, 2021 · 0 comments · Fixed by #3198
Closed

Gearsbot example uses illogical elevaltor setpoints #3151

sciencewhiz opened this issue Feb 2, 2021 · 0 comments · Fixed by #3198
Labels
type: bug Something isn't working.

Comments

@sciencewhiz
Copy link
Contributor

Describe the bug
The GearsBot example uses 5 different elevator setpoints, but there doesn't seem to be much rhyme or reason to them.

On SmartDashboard you can select 0, 0.2, or 0.3
With the gamepad, you can select -0.2 or 0.2
With the PrepareToPickup Command and Pickup Command it uses 0 and 0.25

SmartDashboard.putData("Elevator Bottom", new SetElevatorSetpoint(0, m_elevator));
SmartDashboard.putData("Elevator Platform", new SetElevatorSetpoint(0.2, m_elevator));
SmartDashboard.putData("Elevator Top", new SetElevatorSetpoint(0.3, m_elevator));

dpadUp.whenPressed(new SetElevatorSetpoint(0.2, m_elevator));
dpadDown.whenPressed(new SetElevatorSetpoint(-0.2, m_elevator));

parallel(new SetWristSetpoint(0, wrist), new SetElevatorSetpoint(0, elevator)));

parallel(new SetWristSetpoint(-45, wrist), new SetElevatorSetpoint(0.25, elevator)));

Expected behavior
All elevator setpoints should be consistent

Always using 0 and 0.25, across Smartdashboard, gamepad, and commands, and dropping the 0.3 SmartDashboard one. They could also be made into named constants (#1948).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant