Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Use more logical elevator setpoints in GearsBot #3198

Merged
merged 1 commit into from
Mar 8, 2021
Merged

[examples] Use more logical elevator setpoints in GearsBot #3198

merged 1 commit into from
Mar 8, 2021

Conversation

prateekma
Copy link
Member

Closes #3151

@prateekma prateekma requested review from a team as code owners February 23, 2021 03:00
@auscompgeek
Copy link
Member

Whilst we're here we should make these constants to avoid having to change each setpoint in two places.

@prateekma
Copy link
Member Author

I intentionally left that out because there are a lot of other things to be converted to constants in a separate PR. See #1948.

@prateekma prateekma added cleanup type: docs Related to documentation and information. labels Feb 23, 2021
@AustinShalit AustinShalit merged commit fe341a1 into wpilibsuite:main Mar 8, 2021
@prateekma prateekma deleted the elevator-setpoints branch March 8, 2021 00:00
@AustinShalit AustinShalit added type: chore Formatting, reorganizing, and other necessary (but less impactful) tasks. and removed cleanup labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinShalit AustinShalit AustinShalit approved these changes

@sciencewhiz sciencewhiz Awaiting requested review from sciencewhiz

Assignees
No one assigned
Labels
type: chore Formatting, reorganizing, and other necessary (but less impactful) tasks. type: docs Related to documentation and information.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gearsbot example uses illogical elevaltor setpoints
3 participants
@prateekma @auscompgeek @AustinShalit