Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CommandBase::withName to return CommandBase #3209

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Change CommandBase::withName to return CommandBase #3209

merged 1 commit into from
Mar 4, 2021

Conversation

msoucy
Copy link
Contributor

@msoucy msoucy commented Feb 27, 2021

This allows it to return the same type, retaining the Sendable portion

@msoucy
Change CommandBase::withName to return CommandBase
12c539a 
This allows it to return the same type, retaining the Sendable portion
@msoucy msoucy requested a review from a team as a code owner February 27, 2021 01:01
@prateekma prateekma added component: command-based WPILib Command Based Library type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels Feb 27, 2021
@PeterJohnson PeterJohnson merged commit 1a2680b into wpilibsuite:main Mar 4, 2021
@msoucy msoucy deleted the withname-type branch March 9, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
component: command-based WPILib Command Based Library type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msoucy @PeterJohnson @prateekma