Add flywheel bang-bang controller example #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
reviewed
Mar 3, 2022
...jExamples/src/main/java/edu/wpi/first/wpilibj/examples/flywheelbangbangcontroller/Robot.java
Outdated
Show resolved
Hide resolved
calcmogul
requested changes
Mar 4, 2022
...jExamples/src/main/java/edu/wpi/first/wpilibj/examples/flywheelbangbangcontroller/Robot.java
Outdated
Show resolved
Hide resolved
...jExamples/src/main/java/edu/wpi/first/wpilibj/examples/flywheelbangbangcontroller/Robot.java
Outdated
Show resolved
Hide resolved
|
A C++ version of the example will be needed as well. |
calcmogul
reviewed
Mar 5, 2022
wpilibcExamples/src/main/cpp/examples/flywheelbangbangcontroller/cpp/Robot.cpp
Outdated
Show resolved
Hide resolved
calcmogul
requested changes
Mar 5, 2022
...jExamples/src/main/java/edu/wpi/first/wpilibj/examples/flywheelbangbangcontroller/Robot.java
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/flywheelbangbangcontroller/cpp/Robot.cpp
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/flywheelbangbangcontroller/cpp/Robot.cpp
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/flywheelbangbangcontroller/cpp/Robot.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Tyler Veness <calcmogul@gmail.com>
sciencewhiz
previously requested changes
Mar 14, 2022
wpilibcExamples/src/main/cpp/examples/flywheelbangbangcontroller/cpp/Robot.cpp
Outdated
Show resolved
Hide resolved
...jExamples/src/main/java/edu/wpi/first/wpilibj/examples/flywheelbangbangcontroller/Robot.java
Outdated
Show resolved
Hide resolved
calcmogul
approved these changes
Aug 1, 2023
calcmogul
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a java example on how to use the BangBangController to control a flywheel (#3829). I plan on adding the corresponding C++ example but wanted to get a sanity check as this is my first Pull request to WPIlib.
Few things I was not sure of. If I should show the example using the tolerance constructor or not and how I should go about getting the setpoint for the example. (Right now I am just pulling a basic joystick axis 0)
Thanks!