[wpilib] DataLogManager: increase time for datetime to be valid #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no signal from NetComm as to when it is valid, and 1 second seems to be marginal. Increase to 6 seconds for just DS, 5 seconds for FMS attached.
Starlight220
approved these changes
Mar 12, 2023
|
Is there a way for this to be skipped? What happens if a team starts datalogs before the delay elapses? |
|
@Starlight220 the same thing that happens now: the file is created initially as FRC_TBD_* then renamed. |
|
The main thing worth noting is that all FRC_TBD_* files are deleted on startup, so if the DS is connected for less than this amount of time, the log file will be deleted on next boot. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no signal from NetComm as to when it is valid, and 1 second seems to be marginal. Increase to 6 seconds for just DS, 5 seconds for FMS attached.