Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpiutil] Get more precise system time on Windows #5722

Merged

Conversation

PeterJohnson
Copy link
Member

Windows 8 added GetSystemTimePreciseAsFileTime().

Windows 8 added GetSystemTimePreciseAsFileTime().
@calcmogul
Copy link
Member

Are the other two instances relevant?

wpinet/src/main/native/thirdparty/libuv/src/win/util.cpp
1827:  GetSystemTimeAsFileTime(&file_time);

wpinet/src/main/native/thirdparty/libuv/src/win/fs.cpp
1162:  GetSystemTimeAsFileTime(&ft);

wpiutil/src/main/native/cpp/timestamp.cpp
123:  GetSystemTimeAsFileTime(&ft);

@PeterJohnson
Copy link
Member Author

I don't think we use the util.cpp one anywhere. We may touch the fs.cpp one when reading files? I don't think there's harm in switching them though?

@calcmogul
Copy link
Member

I'll look at making those changes to libuv separately.

@PeterJohnson PeterJohnson merged commit cb1bd0a into wpilibsuite:main Oct 4, 2023
24 checks passed
@PeterJohnson PeterJohnson deleted the windows-precise-system-time branch October 4, 2023 03:38
calcmogul pushed a commit to narmstro2020/allwpilib that referenced this pull request Oct 9, 2023
Windows 8 added GetSystemTimePreciseAsFileTime().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants