Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntcore] Fix crash on disconnect #5788

Merged
merged 3 commits into from
Oct 19, 2023
Merged

[ntcore] Fix crash on disconnect #5788

merged 3 commits into from
Oct 19, 2023

Commits on Oct 19, 2023

  1. [ntcore] Fix crash on disconnect 

    The object was being destroyed due to the error handling path.
Instead, defer to the next loop cycle using a one-shot timer.

Properly handle error return values from Send functions.

Fix UB in accessing one past the end of a vector.
    @PeterJohnson
    PeterJohnson committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    a9258e1 View commit details
    Browse the repository at this point in the history

  2. Use weak pointers

    @PeterJohnson
    PeterJohnson committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    d1baef3 View commit details
    Browse the repository at this point in the history

  3. Revert NetworkServer changes

    @PeterJohnson
    PeterJohnson committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    138c955 View commit details
    Browse the repository at this point in the history