Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds GetTags to C++ version of AprilTagFieldLayout #5872

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Adds GetTags to C++ version of AprilTagFieldLayout #5872

merged 3 commits into from
Nov 4, 2023

Conversation

r4stered
Copy link
Contributor

@r4stered r4stered commented Nov 4, 2023

This adds a small function to return a list of AprilTag objects to the C++ version of the AprilTag library. This already exists in Java.

@r4stered r4stered requested a review from a team as a code owner November 4, 2023 14:42
calcmogul
calcmogul requested changes Nov 4, 2023
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructor taking a size inserts default-constructed elements, then emplace_back() appends after them.

apriltag/src/main/native/cpp/AprilTagFieldLayout.cpp Outdated Show resolved Hide resolved
@r4stered @calcmogul
Removed constructor with size
3aff92c 
Co-authored-by: Tyler Veness <calcmogul@gmail.com>
@PeterJohnson PeterJohnson merged commit 04a781b into wpilibsuite:main Nov 4, 2023
24 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auscompgeek auscompgeek auscompgeek left review comments

@PeterJohnson PeterJohnson PeterJohnson left review comments

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r4stered @auscompgeek @PeterJohnson @calcmogul