Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpilibj] use final for joystick get axis methods #6024

Merged
merged 1 commit into from
Dec 9, 2023
Merged

[wpilibj] use final for joystick get axis methods #6024

merged 1 commit into from
Dec 9, 2023

Conversation

spacey-sooty
Copy link
Contributor

Resolves #6019

@spacey-sooty spacey-sooty requested a review from a team as a code owner December 9, 2023 11:53
@Starlight220
Copy link
Member

These methods are non-virtual in C++, right?

@PeterJohnson
Copy link
Member

Yes

@PeterJohnson PeterJohnson merged commit 7bfadf3 into wpilibsuite:main Dec 9, 2023
25 checks passed
@spacey-sooty spacey-sooty deleted the axis-final branch December 21, 2023 15:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Joystick axis methods final
3 participants
@spacey-sooty @Starlight220 @PeterJohnson