Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sim] Sim GUI DS: Add "Disconnected" state and start in it #6218

Merged
merged 7 commits into from
Jan 21, 2024

Conversation

PeterJohnson
Copy link
Member

The default state for the DS in the simulated HAL is changed to disconnected.

The FMS view is now only editable in DS disconnected state.

This enables more robot and field-like testing of robot code, as the alliance color and other parameters start in invalid states and are only set when the DS connects.

Fixes #6199.

The default state for the DS in the simulated HAL is changed to disconnected.

The FMS view is now only editable in DS disconnected state.

This enables more robot and field-like testing of robot code, as the
alliance color and other parameters start in invalid states and are
only set when the DS connects.
@PeterJohnson PeterJohnson requested review from a team as code owners January 13, 2024 07:04
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor code quality things.

@PeterJohnson PeterJohnson merged commit 3928ed5 into wpilibsuite:main Jan 21, 2024
27 checks passed
@PeterJohnson PeterJohnson deleted the simgui-ds-disconnected branch January 21, 2024 05:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure SimGui triggers on ds connected event, and sets a proper alliance station on enable.
2 participants