Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpimath] Add vector projection and geometry vector conversions #6343

Merged
merged 19 commits into from
Feb 10, 2024
Merged

[wpimath] Add vector projection and geometry vector conversions #6343

merged 19 commits into from
Feb 10, 2024

Conversation

AngleSideAngle
Copy link
Contributor

This PR improves vector math functionality and adds vector getter methods and constructors to Translation2d and Translation3d.

@AngleSideAngle AngleSideAngle requested a review from a team as a code owner February 4, 2024 20:05
@AngleSideAngle
Copy link
Contributor Author

I am using Eigen::Vector2d{x, y} at the moment to initialize vectors. I'm not entirely sure what the difference is, but would it be better to use the parentheses version Eigen::Vector2d(x, y)?

@calcmogul
Copy link
Member

Curly braces inhibits narrowing conversions while parentheses doesn't. Use the former when possible.

@AngleSideAngle
Copy link
Contributor Author

/format

@AngleSideAngle
Copy link
Contributor Author

/format

@AngleSideAngle AngleSideAngle changed the title Add vector projection and geometry getVector methods Add vector projection and geometry toVector methods Feb 4, 2024
AngleSideAngle and others added 4 commits February 4, 2024 20:13
@AngleSideAngle @calcmogul
Update wpimath/src/test/java/edu/wpi/first/math/geometry/Translation3…
a7f80b0 
…dTest.java

Co-authored-by: Tyler Veness <calcmogul@gmail.com>
@AngleSideAngle @calcmogul
Update wpimath/src/test/java/edu/wpi/first/math/geometry/Translation2…
53a095f 
…dTest.java

Co-authored-by: Tyler Veness <calcmogul@gmail.com>
@AngleSideAngle @calcmogul
Apply suggestions from code review
44783f4 
Co-authored-by: Tyler Veness <calcmogul@gmail.com>
@AngleSideAngle
add c++ rotation3d test
ed750d9
@AngleSideAngle
Copy link
Contributor Author

that commit was supposed to be named "add c++ translation3d test"
also, github is blocking this pr from merging because of a suggested change that i resolved but didn't change the referenced line

@AngleSideAngle
Copy link
Contributor Author

/format

@calcmogul
Copy link
Member

I think CMake Windows failed cuz it's using Eigen 3.4.0 (from 2 years ago) instead of our more up-to-date internal version.

@AngleSideAngle AngleSideAngle changed the title Add vector projection and geometry toVector methods [wpimath] Add vector projection and geometry vector conversions Feb 9, 2024
@PeterJohnson PeterJohnson merged commit 62cba9a into wpilibsuite:main Feb 10, 2024
25 checks passed
@AngleSideAngle AngleSideAngle deleted the geometry-vectors branch February 11, 2024 02:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AngleSideAngle @calcmogul @PeterJohnson