[wpimath] Add lastValue() method to filters

[N0tACyb0rg]

Adds the getValue method to return the current value of a SlewRateLimiter without recalculating the value.

[Oblarg]

We should probably name this lastValue to avoid confusion.

…

On Tue, Feb 6, 2024 at 1:15 PM N0tACyb0rg ***@***.***> wrote: @N0tACyb0rg <https://github.com/N0tACyb0rg> requested review from @wpilibsuite/wpilib on: #6351 <#6351> [wpimath] Add getValue method for SlewRateLimiter as a code owner. — Reply to this email directly, view it on GitHub <#6351 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFSPMR7WUT3FGQQALPBKVXDYSJXNBAVCNFSM6AAAAABC4OZ4DKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG4ZDEMZUGEYDOMI> . You are receiving this because your review was requested.Message ID: ***@***.***>

[N0tACyb0rg]

Something like that? Or should it just be lastValue?

[Oblarg]

I prefer lastValue() to getLastValue() (shorter, no risk of confusion) but either is fine.

[N0tACyb0rg]

I actually ended up prefering lastValue() to getLastValue() as well, changed it to that.

[calcmogul]

If we're going to add this, we should add it to all filter classes that can support it (i.e., they've already cached the latest output internally). LinearFilter would return m_outputs.getFirst().

[N0tACyb0rg]

Okay, I'll start working on it.

[N0tACyb0rg]

I added lastValue() methods to the LinearFilter and MedianFilter classes alongside SlewRateLimiter.

[calcmogul]

Now there's a mix of GetValue() and LastValue(). Which do we want?

[N0tACyb0rg]

Sorry about that, brains on autopilot are fun. 😅

[N0tACyb0rg]

That should be the last thing. Let me know if it's good to go and I'll squash the commits.

[N0tACyb0rg]

I squashed the commits, they should be ready to merge now.

[calcmogul]

We autosquash PRs before merge anyway.